Skip to content

[5.1] Yet more minor fixes for property wrappers #25531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DougGregor
Copy link
Member

Fix two more small issues with property wrappers:

  • A crash involving the mutating-ness of accessors in the presence of willSet/didSet: rdar://problem/51669930
  • A SILGen assertion when property wrappers are initialized with tuple values: rdar://problem/50711880

…eclaration.

With property wrappers, the mutating-ness of the accessors can be determined
non-locally by the property wrapper type itself. Ensure that the storage
declaration is consulted to determine the mutating-ness of accessors,
eliminating a crash involving willSet/didSet and property wrappers.

Fixes rdar://problem/51669930.
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit b2758ca into swiftlang:swift-5.1-branch Jun 18, 2019
@DougGregor DougGregor deleted the property-wrappers-more-fixes-5.1 branch June 18, 2019 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant