Under -enable-library-evolution, imports need Library Evolution too #25549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, there's no guarantee of binary compatibility, and whoever turned on library evolution support shouldn't be lulled into a false sense of security. This is just a warning for now, but will be promoted to an error later once clients have shaken out any places where they're doing this. Note that the still-experimental '@_implementationOnly' opts out of this check, because that enforces that the import doesn't make its way into the current module's public source or binary interface. rdar://50261171
jrose-apple
commented
Jun 18, 2019
| /// Swift. | ||
| /// | ||
| /// Right now that's just Clang modules. | ||
| bool isNonSwiftModule() const { |
There was a problem hiding this comment.
I'm planning follow-up work where I check on all uses of findUnderlyingClangModule() that don't actually need to check more than what this predicate is doing.
There was a problem hiding this comment.
Oof, ModuleDecl::isClangModule already exists and I just didn't spot it. This is still a better implementation, but maybe I'll give up on my too-forward-looking name.
There was a problem hiding this comment.
…and the one use of isClangModule is incorrect, because it looks through overlays.
slavapestov
approved these changes
Jun 18, 2019
|
@swift-ci Please smoke test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 18, 2019
…wiftlang#25549) Otherwise, there's no guarantee of binary compatibility, and whoever turned on library evolution support shouldn't be lulled into a false sense of security. This is just a warning for now, but will be promoted to an error later once clients have shaken out any places where they're doing this. Note that the still-experimental '@_implementationOnly' opts out of this check, because that enforces that the import doesn't make its way into the current module's public source or binary interface. rdar://50261171 (cherry picked from commit 2397bf4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, there's no guarantee of binary compatibility, and whoever turned on library evolution support shouldn't be lulled into a false sense of security.
This is just a warning for now, but will be promoted to an error later once clients have shaken out any places where they're doing this. Note that the still-experimental
@_implementationOnlyopts out of this check, because that enforces that the import doesn't make its way into the current module's public source or binary interface.rdar://50261171