-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Android build on macOS Cross-Compile host: Fixes wrong Ninja rules generation. #25576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android build on macOS Cross-Compile host: Fixes wrong Ninja rules generation. #25576
Conversation
@swift-ci please test |
@compnerd Will be nice if you find a time to look on this PR. |
CC: @Rostepher @gottesmm @gwynne @jrose-apple The build complexity is getting pretty absurd at this point. I think that we need to speed up the changes to break the standard library builds into sub-configures so that we can let CMake deal with the flags for the cross-compilation. |
Again, I have no objections as long as the different target platforms continue to build in parallel. |
Thank you! Requested changes seems done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not happy with this, but lets improve things after things are working. Please squash the changes before merging.
@swift-ci please test |
Hm. Seems like CI not picking this PR for smoke test after adding comment Thank you! |
@swift-ci Please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I believe that this is breaking the android SDK builds on Windows :-(. We no longer pass |
Seems like another |
@vgorloff - found the issue, its a dereferencing behavior change in CMake, PR25973 addresses that. |
Cmake generates
rules.ninja
andbuild.ninja
with macOS specific default linker options. That default options (like-dynamiclib -Wl,-headerpad_max_install_names
) cause link errors when performing cross-compilation for Android.Similar fixes for Window host already done. This PR provided fixes for macOS host.