Skip to content

[5.1][CodeCompleiton] Don't hide members for unresolved base types #25579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 18, 2019

Cherry-pick of #25574 into swift-5.1-branch

rdar://problem/49480808

Don't filter out members if the base type has unresolved types.

Previously, initializers used to be hidden if the type has 'where'
requirements on the generic parameters.

This patch enables initializer completion for `SwiftUI.ForEach`.

rdar://problem/49480808
(cherry picked from commit 032c6e6)
@rintaro rintaro changed the title [CodeCompleiton] Don't hide members for unresolved base types [5.1][CodeCompleiton] Don't hide members for unresolved base types Jun 18, 2019
@rintaro
Copy link
Member Author

rintaro commented Jun 18, 2019

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b8a1af3

@rintaro
Copy link
Member Author

rintaro commented Jun 18, 2019

@swift-ci Please test Linux platform

@rintaro rintaro merged commit 008d4f1 into swiftlang:swift-5.1-branch Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants