[5.1 06-12-2019][CodeCompleiton] Don't hide members for unresolved base types #25580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't filter out members if the base type has unresolved types. Previously, initializers used to be hidden if the type has 'where' requirements on the generic parameters. This patch enables initializer completion for `SwiftUI.ForEach`. rdar://problem/49480808 (cherry picked from commit 032c6e6)
|
@swift-ci Please test |
|
@swift-ci Please nominate |
|
Build failed |
|
@swift-ci Please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #25574 into
swift-5.1-branch-06-12-2019TypeName(#HERE#) used to not work without explicit generic argumentsTypeName<Int>(#HERE#because the generic parameters are unresolved. This patch fixes the issue by not hiding members for type with unresolved types.