Skip to content

[5.1 06-12-2019][CodeCompletion] Enable custom attribute completion for func decl #25591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

[5.1 06-12-2019][CodeCompletion] Enable custom attribute completion for func decl #25591

merged 1 commit into from
Jun 19, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 18, 2019 •
edited
Loading

Cherry-pick #25583 into swift-5.1-branch

  • Explanation: Since 952eb9d8, function builders are implemented for function and accessor decls as well. Code completion support for that by suggesting type names for attributes for func decls.
  • Scope: Attribute name completion for function declaration
  • Risk: Very Low. Scope is limited. The change is simple enough.
  • Issue: rdar://problem/50352482
  • Reviewer: Ben Langmuir (@benlangmuir)

@rintaro
[CodeCompletion] Enable custom attribute completion for func decl
c8bc21d 
rdar://problem/50352482
(cherry picked from commit be2fabe)
@rintaro
Copy link
Member Author

rintaro commented Jun 18, 2019

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Jun 19, 2019

@swift-ci Please nominate

@akyrtzi akyrtzi merged commit 3f21a81 into swiftlang:swift-5.1-branch-06-12-2019 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @akyrtzi