TF-587: Default arguments not working in Swift-Jupyter #25664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "IRGen: give non_abi WeakODR linkage" This reverts commit 846a64b.
|
@swift-ci please test tensorflow |
|
Awesome, @marcrasi ! Super speedy too. LGTM |
saeta
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the commit that is at fault and reverted it. I assume that this breaks something in Windows, but I think that swift-jupyter is a higher priority than Windows for S4TF v0.4. I filed https://bugs.swift.org/browse/SR-10994 for a proper fix, so the proper fix should eventually percolate from upstream to our branch.
Resolves https://bugs.swift.org/browse/TF-587.
Revert "IRGen: give non_abi WeakODR linkage"
This reverts commit 846a64b.