[AutoDiff] Not differentiate through global closures flow-sensitively. #25676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier we added a hack to differentiate global constants or variables that are initialized with a closure whose body is differentiable. However, function conversion should not be flow sensitive. This patch removes the hack.
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Jun 22, 2019
| @@ -73,13 +73,6 @@ SimpleMathTests.test("CaptureGlobal") { | |||
| expectEqual(30, gradient(at: 0, in: foo)) | |||
| } | |||
|
|
|||
| let foo: (Float) -> Float = { x in | |||
There was a problem hiding this comment.
Move global closure test to test/AutoDiff/autodiff_diagnostics.swift?
There was a problem hiding this comment.
I'm going to do a more comprehensive patch to disable flow-sensitivity for AD function conversion. PR coming soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we added a hack to differentiate global constants or variables that are initialized with a closure whose body is differentiable. However, function conversion should not be flow-sensitive. This patch removes the hack.