[Runtime] Add dump() methods to TypeContextDescriptor and EnumDescriptor. #25705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
gottesmm
reviewed
Jun 24, 2019
| template <> | ||
| LLVM_ATTRIBUTE_USED | ||
| void TypeContextDescriptor::dump() const { | ||
| printf("TargetTypeContextDescriptor.\n"); |
There was a problem hiding this comment.
Looks awesome! My only question is why you are using this in only some of the places.
There was a problem hiding this comment.
I banged these out while debugging a problem and figured I should add them in. We should definitely make more though.
There was a problem hiding this comment.
No that isn't what I meant. I meant in some parts you are using "this->" and others you aren't.
There was a problem hiding this comment.
Oh, this! Hah. The compiler complained about not finding those fields without it. I don't really understand why.
There was a problem hiding this comment.
From talking with JoeG it is due to dependent member lookup and c++ being what it is. This looks great to me!
gottesmm
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.