[5.1] [ModuleInterface] Explicitly print implied Hashable et al on enums #25709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ang#25662) Previously the module interface printing would scrape the AvailableAttrs from the containing decl in order to print synthesized extensions for conformances that wouldn't otherwise be printed...but that missed the case where a containing lexical scope had the availability attributes instead. Now it walks up the chain of parent DeclContexts and collects the most specific AvailableAttr for each platform. This /still/ isn't formally correct because it doesn't merge availability for one platform (if something inside is deprecated unconditionally but outside has an "introduced" version), but it's going to match the vast majority of code out there. Pre-requisite for rdar://problem/50100142 (cherry picked from commit 15bcd23)
…wiftlang#25650) Enums have a handful of conformances that are implied by their structure: Equatable and Hashable if they have no payloads, and RawRepresentable if they have a raw value. In the spirit of making implicit things explicit, these should be printed in the module interface. rdar://problem/50100142 (cherry picked from commit b668017)
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #25662 and #25650 to the 5.1 branch. Reviewed by @harlanhaskins.
rdar://problem/50100142