[5.1][AST] Increase size of type variable id field to 20 bits #25716
+309
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `id` field is only 12 bits long which is a lot smaller than `graph index` which is 28 bits and creates problems with large collections of literals since `id` is going to overflow pretty quickly (4096 elements max). Let's change it so both fields have the same 20 bits which is big enough. Resolves: [SR-10914](https://bugs.swift.org/browse/SR-10914) Resolves: rdar://problem/51616307
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
idfield is only 12 bits long which is a lot smallerthan
graph indexwhich is 28 bits and creates problems withlarge collections of literals since
idis going to overflowpretty quickly (4096 elements max). Let's change it so both
fields have the same 20 bits which is big enough.
Resolves: SR-10914
Resolves: rdar://problem/51616307
Cherry-pick of #25666