Skip to content

[5.1][ConstraintSystem] Shrink: If root expression is assignment always co… #25753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 25, 2019

…nsider it as a candidate

If assignment expression is not considered as a top-level candidate
it would mean that other candidates would be allowed to produce
types inconsistent with destination type of the assignment.

Resolves: rdar://problem/51413254
(cherry picked from commit 93ab669)

@xedin
Copy link
Contributor Author

xedin commented Jun 25, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 45b1e5913ef4a499f1aa0a17c6ec49737b777f16

…nsider it as a candidate

If assignment expression is not considered as a top-level candidate
it would mean that other candidates would be allowed to produce
types inconsistent with destination type of the assignment.

Resolves: rdar://problem/51413254
(cherry picked from commit 93ab669)
@xedin xedin force-pushed the rdar-51413254-5.1 branch from 45b1e59 to 575ef3b Compare June 25, 2019 18:06
@xedin
Copy link
Contributor Author

xedin commented Jun 25, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 45b1e5913ef4a499f1aa0a17c6ec49737b777f16

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 45b1e5913ef4a499f1aa0a17c6ec49737b777f16

@xedin xedin merged commit ae66180 into swiftlang:swift-5.1-branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants