Skip to content

[5.1][CodeCompletion] Use unresolved member completion for case stmt beginning #25763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2019
Merged

[5.1][CodeCompletion] Use unresolved member completion for case stmt beginning #25763

merged 2 commits into from
Jun 26, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 25, 2019

Cherry-pick of #25755 into swift-5.1-branch reviewed by @benlangmuir

rdar://problem/45219937

rintaro added 2 commits June 25, 2019 14:41
@rintaro
[CodeCompletion] Remove completeCaseStmtDotPrefix() completion
cedc5c2 
Now that, normal dot-member completion works at case position. We don't
need to handle it specially.

rdar://problem/45219937
(cherry picked from commit 588d87b)
@rintaro
[CodeCompletion] Remove getTypeContextEnumElementCompletions()
d81a2b0 
Use getUnresolvedmemberCompletion() instead.

rdar://problem/45219937
(cherry picked from commit 35f8686)
@rintaro
Copy link
Member Author

rintaro commented Jun 25, 2019

@swift-ci Please test

@rintaro rintaro merged commit c88203d into swiftlang:swift-5.1-branch Jun 26, 2019
@rintaro rintaro deleted the 5.1-ide-completion-casebeginning-rdar45219937 branch June 26, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rintaro