Skip to content

[Syntax] Fix tuple type element parsing #25843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 27, 2019

Found by @jansvoboda11

  • Typo: InoutToken not InOutToken
  • Use EllipsisToken like function parameters. Otherwise , is stored at ellipsis position.

rdar://problem/52291805

@rintaro rintaro requested a review from nkcsgexi June 27, 2019 23:06
@rintaro
Copy link
Member Author

rintaro commented Jun 27, 2019

@swift-ci Please smoke test

@rintaro rintaro force-pushed the syntax-tupletype-element-rdar52291805 branch from 7de0162 to 0829892 Compare June 27, 2019 23:19
@rintaro
Copy link
Member Author

rintaro commented Jun 27, 2019

@swift-ci Please smoke test

* typo: `InoutToken` not `InOutToken`
* Use `EllipsisToken` like function parameters. Otherwise `,` is stored
  at ellipsis position.

rdar://problem/52291805
@rintaro rintaro force-pushed the syntax-tupletype-element-rdar52291805 branch from 0829892 to 9c044fe Compare June 27, 2019 23:35
@rintaro
Copy link
Member Author

rintaro commented Jun 27, 2019

@swift-ci Please smoke test

@rintaro rintaro merged commit b2fd31d into swiftlang:master Jun 28, 2019
@rintaro rintaro deleted the syntax-tupletype-element-rdar52291805 branch June 28, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants