-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Gardening] Remove extra Foundation imports #25853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove the import of Foundation where it is not necessary for testing the ObjC interop.
@swift-ci please benchmark |
@swift-ci please smoke test |
Performance: -O
Code size: -OPerformance: -Osize
Code size: -OsizePerformance: -Onone
Code size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
Those regressions and improvements in |
There are a few things that behave differently based on whether the Foundation overlays are linked into the process. :-( The set is kept pretty small but it could still be an explanation here. cc @Catfish-Man |
@swift-ci please benchmark |
Performance: -O
Code size: -OPerformance: -Osize
Code size: -OsizePerformance: -Onone
Code size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
(Please address compnerd's request)
Import functions from standard C library on Windows.
@swift-ci please benchmark |
@swift-ci smoke test |
Performance: -O
Code size: -OPerformance: -Osize
Code size: -OsizePerformance: -OnoneCode size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
Remove the import of Foundation where it is not necessary for testing the ObjC interoperability.
Edit: Also import MSVCRT in Windows where the
#if os(Linux) import Glibc
pattern occurs.