[Index] Don't index non-public imported declarations #25865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Oops, missed a test change. |
jrose-apple
force-pushed
the
sleeping-dragons
branch
from
9698a47 to
18e892c
Compare
Apart from mildly speeding up indexing, this also keeps the compiler from running into issues with implementation-only imports that may not be present while we're trying to index. rdar://problem/52083709
jrose-apple
force-pushed
the
sleeping-dragons
branch
from
18e892c to
bf84429
Compare
jrose-apple
commented
Jun 28, 2019
| { | ||
| key.kind: source.lang.swift.decl.extension.class, | ||
| key.name: "C2", | ||
| key.usr: "s:e:s:11test_module2C2C6SECRETyyF" |
There was a problem hiding this comment.
This change does mean extensions might exist with USRs that refer to decls that aren't indexed. Is that a problem?
|
Build failed |
|
Build failed |
akyrtzi
approved these changes
Jun 28, 2019
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 28, 2019
Apart from mildly speeding up indexing, this also keeps the compiler from running into issues with implementation-only imports that may not be present while we're trying to index. rdar://problem/52083709 (cherry picked from commit 02e1a11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from mildly speeding up indexing, this also keeps the compiler from running into issues with implementation-only imports that may not be present while we're trying to index.
rdar://problem/52083709