Diagnose usages of 'Self' in stored property initializers #25877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the captures for each stored property initializer separately, instead of incorporating them into the capture list of each designated initializer. Fixes <rdar://problem/41490541>
…zers A stored property initializer does not have access to either the 'self' instance or the 'Self' type, so SILGen would just crash when emitting one containing a reference to 'Self'. With some work on SILGen we could probably allow this, but for now let's diagnose instead of crashing. Fixes <rdar://problem/51561208>, <https://bugs.swift.org/browse/SR-10969>.
|
@swift-ci Please smoke test |
|
apple/swift-lldb#1757 |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of walking stored property initializer expressions as part of computing the captures for a designated initializer, walk and store them separately. This makes more sense since SILGen emits them as separate functions.
Also, diagnose DynamicSelfType references inside stored property initializers, which are currently not supported.
Fixes rdar://problem/41490541, rdar://problem/51561208, https://bugs.swift.org/browse/SR-10969.