[5.1][Diagnostics] Add property wrapper diagnostic for unnecessary $/'_' i… #25878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n member access Detect and diagnose incorrect use of `$` or `_` while referencing members. Also: - Refactor some of the logic for the original missing `$` diagnostic, so that a lot of logic can be shared between the two. - Rename the original fix and diagnostic to better reflect their purpose. Resolves: [SR-10928](https://bugs.swift.org/browse/SR-10928) Resolves: rdar://problem/51580712
xedin
changed the title
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n member access
Detect and diagnose incorrect use of
$or_while referencing members.Also:
Refactor some of the logic for the original missing
$diagnostic,so that a lot of logic can be shared between the two.
Rename the original fix and diagnostic to better reflect their purpose.
Resolves: SR-10928
Resolves: rdar://problem/51580712