Skip to content

ARCCodeMotion: add debug tracing. #25901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2019
Merged

ARCCodeMotion: add debug tracing. #25901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 43 additions & 5 deletions lib/SILOptimizer/Transforms/ARCCodeMotion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@ class CodeMotionContext {
/// we compute the genset and killset.
llvm::SmallPtrSet<SILBasicBlock *, 8> InterestBlocks;

#ifndef NDEBUG
// SILPrintContext is used to print block IDs in RPO order.
// It is optional so only the final insertion point interference is printed.
Optional<SILPrintContext> printCtx;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of printCtx? To set the SortedSIL flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment:

+  // SILPrintContext is used to print block IDs in RPO order.
+  // It is optional so only the final insertion point interference is printed.
   Optional<SILPrintContext> printCtx;

It looks like I copied this from RLE's debug output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, makes sense. Thanks

#endif

/// Return the rc-identity root of the SILValue.
SILValue getRCRoot(SILValue R) {
return RCFI->getRCIdentityRoot(R);
Expand Down Expand Up @@ -308,14 +314,23 @@ class RetainCodeMotionContext : public CodeMotionContext {
return true;
// Identical RC root blocks code motion, we will be able to move this retain
// further once we move the blocking retain.
if (isRetainInstruction(II) && getRCRoot(II) == Ptr)
if (isRetainInstruction(II) && getRCRoot(II) == Ptr) {
LLVM_DEBUG(if (printCtx) llvm::dbgs()
<< "Retain " << Ptr << " at matching retain " << *II);
return true;
}
// Ref count checks do not have side effects, but are barriers for retains.
if (mayCheckRefCount(II))
if (mayCheckRefCount(II)) {
LLVM_DEBUG(if (printCtx) llvm::dbgs()
<< "Retain " << Ptr << " at refcount check " << *II);
return true;
}
// mayDecrement reference count stops code motion.
if (mayDecrementRefCount(II, Ptr, AA))
if (mayDecrementRefCount(II, Ptr, AA)) {
LLVM_DEBUG(if (printCtx) llvm::dbgs()
<< "Retain " << Ptr << " at may decrement " << *II);
return true;
}
// This instruction does not block the retain code motion.
return false;
}
Expand Down Expand Up @@ -398,6 +413,8 @@ void RetainCodeMotionContext::initializeCodeMotionDataFlow() {
continue;
RCRootIndex[Root] = RCRootVault.size();
RCRootVault.insert(Root);
LLVM_DEBUG(llvm::dbgs()
<< "Retain Root #" << RCRootVault.size() << " " << Root);
}
}

Expand Down Expand Up @@ -560,6 +577,9 @@ void RetainCodeMotionContext::convergeCodeMotionDataFlow() {
}

void RetainCodeMotionContext::computeCodeMotionInsertPoints() {
#ifndef NDEBUG
printCtx.emplace(llvm::dbgs(), /*Verbose=*/false, /*Sorted=*/true);
#endif
// The BBSetOuts have converged, run last iteration and figure out
// insertion point for each refcounted root.
for (SILBasicBlock *BB : PO->getReversePostOrder()) {
Expand Down Expand Up @@ -667,11 +687,17 @@ class ReleaseCodeMotionContext : public CodeMotionContext {
return true;
// Identical RC root blocks code motion, we will be able to move this release
// further once we move the blocking release.
if (isReleaseInstruction(II) && getRCRoot(II) == Ptr)
if (isReleaseInstruction(II) && getRCRoot(II) == Ptr) {
LLVM_DEBUG(if (printCtx) llvm::dbgs()
<< "Release " << Ptr << " at matching release " << *II);
return true;
}
// Stop at may interfere.
if (mayHaveSymmetricInterference(II, Ptr, AA))
if (mayHaveSymmetricInterference(II, Ptr, AA)) {
LLVM_DEBUG(if (printCtx) llvm::dbgs()
<< "Release " << Ptr << " at interference " << *II);
return true;
}
// This instruction does not block the release.
return false;
}
Expand Down Expand Up @@ -771,6 +797,8 @@ void ReleaseCodeMotionContext::initializeCodeMotionDataFlow() {
continue;
RCRootIndex[Root] = RCRootVault.size();
RCRootVault.insert(Root);
LLVM_DEBUG(llvm::dbgs()
<< "Release Root #" << RCRootVault.size() << " " << Root);
}
if (MultiIteration && BB.getTerminator()->isFunctionExiting())
Worklist.push_back(&BB);
Expand Down Expand Up @@ -972,6 +1000,10 @@ void ReleaseCodeMotionContext::convergeCodeMotionDataFlow() {
}

void ReleaseCodeMotionContext::computeCodeMotionInsertPoints() {
#ifndef NDEBUG
printCtx.emplace(llvm::dbgs(), /*Verbose=*/false, /*Sorted=*/true);
#endif

// The BBSetIns have converged, run last iteration and figure out insertion
// point for each RC root.
for (SILBasicBlock *BB : PO->getPostOrder()) {
Expand All @@ -991,6 +1023,9 @@ void ReleaseCodeMotionContext::computeCodeMotionInsertPoints() {
if (!SBB->BBSetIn[i])
continue;
InsertPoints[RCRootVault[i]].push_back(&*(*Succ).begin());
LLVM_DEBUG(llvm::dbgs()
<< "Release partial merge. Insert at successor: "
<< printCtx->getID(BB) << " " << RCRootVault[i]);
}
}

Expand All @@ -1010,6 +1045,9 @@ void ReleaseCodeMotionContext::computeCodeMotionInsertPoints() {
if (!SBB->BBSetIn[i])
continue;
InsertPoints[RCRootVault[i]].push_back(&*(*Succ).begin());
LLVM_DEBUG(llvm::dbgs()
<< "Release terminator use. Insert at successor: "
<< printCtx->getID(BB) << " " << RCRootVault[i]);
}
S->BBSetOut.reset(i);
}
Expand Down