[code-completion] Disable diagnostics in @functionBuilder bodies #25922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: we have #24842 open to do this for all code-completions, but we need to figure out a plan to recover from the regressions that we saw there. For now, just do this for DSL closures. |
|
@swift-ci please test |
|
@swift-ci please test |
rintaro
approved these changes
Jul 1, 2019
xedin
approved these changes
Jul 1, 2019
When performing code-completion inside the body of a @functionBuilder closure/function, set the flag to suppress diagnostics. This works around a big performance problem in some complex bodies that do not typecheck, which is typical during code-completion. A real-world example with SwitfUI went from ~50 seconds to 0.5. We do not disable diagnostics in general because the diagnostic paths provide falback types that are useful to code-completion. rdar://52356229
benlangmuir
force-pushed
the
cc-dsl-slow
branch
2 times, most recently
from
8f33ec2 to
c6eade1
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing code-completion inside the body of a @functionBuilder
closure/function, set the flag to suppress diagnostics. This works
around a big performance problem in some complex bodies that do not
typecheck, which is typical during code-completion. A real-world example
with SwitfUI went from ~50 seconds to 0.5. We do not disable diagnostics
in general because the diagnostic paths provide falback types that are
useful to code-completion.
rdar://52356229