[AST] Properly recurse when reconstituting sugar #25937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently even when `reconstituteSugar`'s `Recursive` parameter is set to `true`, we stop rebuilding sugar upon hitting a desugared type. For example `Optional<Optional<Int>>` will only be re-sugared to `Optional<Int>?`. This commit changes the behaviour so we continue recursing into the generic argument.
|
cc. @slavapestov |
DougGregor
approved these changes
Jul 5, 2019
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently even when
reconstituteSugar'sRecursiveparameter is set totrue, we stop rebuilding sugar upon hitting a desugared type. For exampleOptional<Optional<Int>>will only be re-sugared toOptional<Int>?. This PR changes the behaviour so we continue recursing into the generic argument.(Noticed by inspection)