Skip to content

[5.1] SourceKit/Indentation: avoid indenting closing paren of function-like decls if it appears in a new line #25943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Jul 2, 2019

Explanation: The automatic indentation of closing parens for function-like decls needs to be corrected according to the recommendation.
Scope: Editor tooling/Indentation
Issue: rdar://51719094
Risk: Very Low, doesn't affect anything in the compiler side
Testing: Regression tests added
Reviewer: Argyrios Kyrtzidis (@akyrtzi)

… decls if it appears in a new line

rdar://51719094
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jul 2, 2019

@swift-ci please test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jul 2, 2019

@swift-ci please nomimate

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jul 2, 2019

@swift-ci please nominate

@nkcsgexi nkcsgexi merged commit 321f3d3 into swiftlang:swift-5.1-branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant