Don't emit the FORCE_LOAD symbols when the compiler is running #25966
Conversation
on behalf of the debugger. The debugger will read the LinkLibrary's from all the modules it sees, and hand load all the required dependencies, and since the symbol is weak it doesn't even tell us whether a required dependency is missing. So it serves no purpose in this case. <rdar://problem/51463642>
|
@swift-ci please test |
lib/IRGen/IRGenModule.cpp
Outdated
| // from all the modules it sees, and hand load all the required dependencies, | ||
| // and since the symbol is weak it doesn't even tell us whether a | ||
| // required dependency is missing. So it serves no purpose in this case. | ||
| if (linkLib.shouldForceLoad() && !Context.LangOpts.DebuggerSupport) { |
There was a problem hiding this comment.
A belated thought: given that the debugger is going to read the LinkLibrarys itself, maybe it shouldn't even bother generating the metadata above either. You could just bail out at the top of the function.
There was a problem hiding this comment.
I'll give that a try and see if lldb and the REPL are still happy.
There was a problem hiding this comment.
That also works, and lldb seems happy.
So it is simpler to just early return when we are running on the debugger's behalf.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
lib/IRGen/IRGenModule.cpp
Outdated
| // from all the modules it sees, and hand load all the required dependencies. | ||
| // so it doesn't need this information. And since the FORCE_LOAD symbol is | ||
| // weak it doesn't even tell us whether a required dependency is missing. | ||
| // So it serves no purpose in this case. |
There was a problem hiding this comment.
Looks good, but the comment is no longer accurate. I think it can just be "The debugger can get autolink information directly from the LinkLibraries of the module, so there's no reason to generate it in the LLVM IR."
|
@swift-ci please test |
|
@jrose-apple: Does that look better? |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
I was moving this around per Jordan's request and didn't change the valance of the if test.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
Don't emit the FORCE_LOAD symbols when the compiler is running
Merge pull request #25966 from jimingham/master
on behalf of the debugger. The debugger will read the LinkLibrary's
from all the modules it sees, and hand load all the required dependencies,
and since the symbol is weak it doesn't even tell us whether a
required dependency is missing. So it serves no purpose in this case.
rdar://problem/51463642
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.