Update example code to compile with Swift 5.0/5.1 #25995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took inspiration from Filter.swift as to modern syntax to use, though didn't convert `private` properties to `internal`.
|
Now that bugs.swift.org is back up an Issue has been created for this defect: https://bugs.swift.org/browse/SR-11084 |
xwu
reviewed
Jul 8, 2019
Removed private scope on properties to enable synthesized initializers; removed previously added explicit initializers; add necessary parameter label.
xwu
reviewed
Jul 9, 2019
remove ill advised usability change Co-Authored-By: Xiaodi Wu <[email protected]>
Co-Authored-By: Xiaodi Wu <[email protected]>
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LazySequence documentation sample code for the "we can build a sequence that lazily computes the elements in the result of
scan" example so that it will compile and work for Swift 5.0 & 5.1