Add Identifiable protocol to the standard library #26022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airspeedswift
requested changes
Jul 9, 2019
Azoy
reviewed
Jul 9, 2019
|
@airspeedswift now that this has been accepted I’ll get the PR rebased on the latest master. Are there any other changes that need to happen before it is ready to merge? Additional documentation as mentioned in the review rationale? |
|
@anandabits Let's land the code as is -- we can figure out the docs later. |
lorentey
approved these changes
Jul 26, 2019
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements SE-0261. It will be updated with any changes after the core team makes a final decision. Please let me know if it should target a different branch.