[test] Verify that TypeDecoder handles same-type constraints properly #26045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
jrose-apple
commented
Jul 10, 2019
test/TypeDecoder/nominal_types.swift
Outdated
| // CHECK-TYPE: STSContainer℠<STSOuter>.Subclass2<Int> | ||
|
|
||
| // DEMANGLE-TYPE: $s13nominal_types12STSContainerO9Subclass3CyAA8STSOuterV_SiG | ||
| // CHECK-TYPE: STSContainer<STSOuter>.Subclass3<Int> |
There was a problem hiding this comment.
Oops. This one has a constraint on it and I'm not passing a valid argument. It's working by coincidence because I wrote the wrong mangled name.
Follow-up for 4b8068d recommended by Slava.
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
|
@slavapestov Ping. I think there's no downside to taking these tests, even if we have to leave the Remote* ones for later? |
slavapestov
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #25984 recommended by Slava. (RemoteAST is next but that might actually have problems…or I might be holding it wrong.)