[android] Remove dependency from SwiftShims to Libc #26079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that SwiftShims cannot import some system headers (checked by a test in test/ParseableInterface/ModuleCache/SystemDependencies). So adding <android/api-level.h> is not going to work. The change reproduces the only piece necessary from the header, which is interpreting that if no __ANDROID_API__ is defined, the level should be the maximum allowed.
|
@swift-ci please smoke test |
compnerd
approved these changes
Jul 11, 2019
|
Yes, SwiftShims can't import libc things because it makes cycles with the Glibc overlay later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that SwiftShims cannot import some system headers (checked by a
test in test/ParseableInterface/ModuleCache/SystemDependencies). So
adding <android/api-level.h> is not going to work.
The change reproduces the only piece necessary from the header, which is
interpreting that if no ANDROID_API is defined, the level should be
the maximum allowed.