[Request-evaluator] Graphviz visualization of cross-file dependencies #26084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a stub request for type checking a function body. It’s currently not triggered lazily, but we’ll start migrating the synthesis and type-checking logic here.
Use the "nearest source location" information on a request to map it to a particular source buffer, then use that information in the GraphViz dependency graphs so we can see cross-file dependencies more clearly.
…ce buffers To help make the current GraphViz output of the dependency graph more legible, introduce "fake" nodes for the source buffers we encounter, and draw edges from those nodes to any requests associated with those source buffers that have no other edges leading to them. This is a temporary visualization hack, to be replaced by proper "top-level" requests for things like type-checking an entire source file.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the GraphViz output of the request-evaluator's dependency graph to color-code the requests based on the source files with which the requests are associated. Cross-file dependencies show up as edges among nodes of different colors. This won't scale to large files, but it's nice for visualizing small ones. The graph is still fairly sparse because we're missing many useful requests.