Skip to content

[ConstraintSystem] trySimplifyToExpr shouldn't rely on locator bein… #26086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 11, 2019

…g always anchored

If constraint system is used as part of the declaration checker to
e.g. verify generic requirements for a witness, locators are not going
to have an anchor.

Resolves: SR-10728
Resolves: rdar://problem/50987089

@xedin xedin requested a review from DougGregor July 11, 2019 08:06
@xedin
Copy link
Contributor Author

xedin commented Jul 11, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jul 11, 2019

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0d9ef6975efa29ece664904169b1a217274c86ba

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0d9ef6975efa29ece664904169b1a217274c86ba

…g always anchored

If constraint system is used as part of the declaration checker to
e.g. verify generic requirements for a witness, locators are not going
to have an anchor.

Resolves: [SR-10728](https://bugs.swift.org/browse/SR-10728)
Resolves: rdar://problem/50987089
@xedin
Copy link
Contributor Author

xedin commented Jul 11, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jul 11, 2019

@swift-ci please test source compatibility

@xedin xedin merged commit d2a0757 into swiftlang:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants