Replace all 9999 availability in non-stdlib tests. #26109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jckarter Mainly tagging you to check that you folks haven't yet added anything to these tests that actually shouldn't be available when building for 5.1, and that there aren't other reasons to maintain 9999 for these. |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Linux failure is in LLDB, looks unrelated to this change: 09:44:25 error: missing required modules: 'Swift', 'SwiftOnoneSupport' Modules again? |
|
@swift-ci smoke test linux |
|
Checked in with @dcci about the LLDB failures, we think this is not a PR blocker, so merging with the linux smoke-test only. |
stephentyrone
added a commit
to stephentyrone/swift
that referenced
this pull request
Jul 15, 2019
Replace all 9999 availability in non-stdlib tests with the appropriate platform availability.
stephentyrone
added a commit
that referenced
this pull request
Jul 16, 2019
…6145) * Replace all 9999 availability in non-stdlib tests. (#26109) Replace all 9999 availability in non-stdlib tests with the appropriate platform availability. * Merge pull request #26129 from aschwaighofer/fix_test_dynamic_replacement_opaque_result Fix test/Interpreter/dynamic_replacement_opaque_result.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #26108