AST: add a workaround for VS2017 #26111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, VS2017 does not support the SFINAE expression. This means that it attempts to parse the `Index < sizeof...(Types)` as a template parameter resulting in a parse failure. This normalises the constraint to `0 < sizeof...(Types) - Index` (`sizeof...(Types) - Index > 0`) which is then wrapped into a ternary to explicitly convert it to a boolean. This repairs the builds on VS2017.
|
CC: @DougGregor |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Going to merge this to unbreak the bots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, VS2017 does not support the SFINAE expression. This
means that it attempts to parse the
Index < sizeof...(Types)as atemplate parameter resulting in a parse failure. This normalises the
constraint to
0 < sizeof...(Types) - Index(
sizeof...(Types) - Index > 0) which is then wrapped into a ternary toexplicitly convert it to a boolean. This repairs the builds on VS2017.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.