AST: Remove LiteralExpr::shallowClone() #26118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
pschuh
approved these changes
Jul 12, 2019
pschuh
reviewed
Jul 12, 2019
| @@ -6685,26 +6685,9 @@ Expr *ExprRewriter::convertLiteralInPlace(Expr *literal, | |||
| DeclName builtinLiteralFuncName, | |||
| Diag<> brokenProtocolDiag, | |||
| Diag<> brokenBuiltinProtocolDiag) { | |||
| auto &tc = cs.getTypeChecker(); | |||
There was a problem hiding this comment.
... or not enough deleting further down! See updated version :)
slavapestov
force-pushed
the
shallow-clone-be-gone
branch
from
6c6fd3c to
866cd4d
Compare
|
@swift-ci Please smoke test |
At one point it was used to work around problems with re-type checking literals in CSApply, but all of our tests appear to pass with this removed.
slavapestov
force-pushed
the
shallow-clone-be-gone
branch
from
866cd4d to
5022d8b
Compare
|
@swift-ci Please smoke test |
slavapestov
commented
Jul 12, 2019
| @@ -2,5 +2,5 @@ | |||
|
|
|||
| func test(_ x: Int) -> Int { | |||
| return x + nil | |||
| // expected-error@-1 {{cannot convert value of type 'Int' to expected argument type '_.Stride'}} | |||
| // expected-error@-1 {{type of expression is ambiguous without more context}} | |||
There was a problem hiding this comment.
@xedin I noticed this diagnostic did change. Are you OK with this? The test case was originally added when a crash was fixed. I don't think the old diagnostic actually gave you any useful information (the real problem is there's no suitable overload of + -- as far as I can see the appearance of Stride in the old message is an emergent behavior of CSDiag and CalleeCandidateDiagnostics)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one point it was used to work around problems with re-type checking
literals in CSApply, but all of our tests appear to pass with this removed.