Skip to content

Refactor so that we check FOR the token instead of the lack of one #26122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactor so that we check FOR the token instead of the lack of one #26122

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2019

This makes the code more secure.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

theblixguy
theblixguy requested changes Jul 12, 2019
View reviewed changes
Copy link
Collaborator

@theblixguy theblixguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The early return is better as it helps reduce indentation and makes code clearer.

@ghost ghost closed this Jul 20, 2019
@ghost ghost deleted the patch-1 branch July 20, 2019 17:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theblixguy