Skip to content

[ModuleInterface] Create module cache path if we install a forwarding module #26127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2019
Merged

[ModuleInterface] Create module cache path if we install a forwarding module #26127

merged 1 commit into from
Jul 13, 2019

Conversation

harlanhaskins
Copy link
Contributor

@harlanhaskins harlanhaskins commented Jul 13, 2019 •
edited
Loading

If we are installing a forwarding module to something in the prebuilt
cache, make sure to create the module cache directory if it doesn't
exist.

rdar://53011893

@harlanhaskins harlanhaskins force-pushed the create-module-cache-for-forwarding-modules branch from 77ca2ac to e0fa20a Compare July 13, 2019 00:36
[ModuleInterface] Create module cache path if we install a forwarding…
db7a726 
… module

If we are installing a forwarding module to something in the prebuilt
cache, make sure to create the module cache directory if it doesn't
exist.

rdar://52964217
@harlanhaskins harlanhaskins force-pushed the create-module-cache-for-forwarding-modules branch from e0fa20a to db7a726 Compare July 13, 2019 00:37
@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test and merge

@shahmishal
Copy link
Member 

18:11:03 ******************** TEST 'LLDB :: SwiftREPL/ExclusivityREPL.test' FAILED ********************
18:11:03 Script:
18:11:03 --
18:11:03 : 'RUN: at line 3';   /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/buildbot_incremental/lldb-macosx-x86_64/bin/lldb --no-lldbinit -S /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/buildbot_incremental/lldb-macosx-x86_64/lit/lit-lldb-init --repl < /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/lldb/lit/SwiftREPL/ExclusivityREPL.test 2>&1 | /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/buildbot_incremental/llvm-macosx-x86_64/bin/FileCheck /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/lldb/lit/SwiftREPL/ExclusivityREPL.test
18:11:03 --
18:11:03 Exit Code: 74
18:11:03 
18:11:03 
18:11:03 ********************

jrose-apple
jrose-apple previously requested changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. We're only supposed to create one level of directory; if you put the path somewhere totally random, we don't want to make the whole chain. That's user error.

…unless Clang makes the whole chain, in which case okay whatever.

@shahmishal
Copy link
Member

@swift-ci smoke test macOS

@harlanhaskins
Copy link
Contributor Author

@jrose-apple Clang does create intermediate directories

https://github.com/apple/swift-clang/blob/stable/lib/Frontend/CompilerInstance.cpp#L2090

@jrose-apple jrose-apple dismissed their stale review July 13, 2019 01:46

Consistency with Clang is more important than my ideal here.

@harlanhaskins harlanhaskins merged commit 1cbb85b into swiftlang:master Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

@jrose-apple jrose-apple jrose-apple left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harlanhaskins @shahmishal @akyrtzi @jrose-apple