[AutoDiff] Move Differentiation before OwnershipModelEliminator. #26157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
force-pushed
the
ownership
branch
4 times, most recently
from
2447939 to
4ba9e7a
Compare
rxwei
force-pushed
the
ownership
branch
3 times, most recently
from
69d0849 to
6e948f9
Compare
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
Jul 28, 2019
…nks. In `ADContext::promoteToDifferentiableFunction` when we emit a subset parameters thunk, the closure produced by `emitAssociatedFunctionReference` is not being used or released. This patch fixes that by releasing the closure. In a future design, we should determine the actual parameter indices and whether thunking is needed before emitting an unused closure. This shall be addressed in a future patch. A value leak checking test was added for protocols because this bug was originally discovered in eaplatanios/swift-ale#1 by using the newly split `Layer` protocol. However, value leak checking tests do not test for closure (`partial_apply`) leaks. The proper setup for catching closure leaks is moving AD before ownership stripping (swiftlang#26157).
rxwei
added a commit
that referenced
this pull request
Jul 28, 2019
…nks. (#26384) In `ADContext::promoteToDifferentiableFunction` when we emit a subset parameters thunk, the closure produced by `emitAssociatedFunctionReference` is not being used or released. This patch fixes that by releasing the closure. In a future design, we should determine the actual parameter indices and whether thunking is needed before emitting an unused closure. This shall be addressed in a future patch. A value leak checking test was added for protocols because this bug was originally discovered in eaplatanios/swift-ale#1 by using the newly split `Layer` protocol. However, value leak checking tests do not test for closure (`partial_apply`) leaks. The proper setup for catching closure leaks is moving AD before ownership stripping (#26157).
|
@rxwei question. How many bugs have you guys found so far through this? 3? |
|
@gottesmm More than 5 and counting :) |
rxwei
force-pushed
the
ownership
branch
3 times, most recently
from
023b9cb to
4ed2883
Compare
rxwei
force-pushed
the
ownership
branch
2 times, most recently
from
76f43b2 to
ad8144f
Compare
rxwei
commented
Aug 17, 2019
| @@ -4908,14 +5016,19 @@ class PullbackEmitter final : public SILInstructionVisitor<PullbackEmitter> { | |||
| auto activeValueAdj = getAdjointValue(origBB, activeValue); | |||
| auto concreteActiveValueAdj = | |||
| materializeAdjointDirect(activeValueAdj, loc); | |||
| trampolineArguments.push_back(concreteActiveValueAdj); | |||
|
|
|||
| if (!adjointTrampolineBlockMap.count(concreteActiveValueAdj)) { | |||
There was a problem hiding this comment.
This logic is hacky and is not straightforward to describe. Fortunately it will be defined away with the upcoming ad-all-indirect that @dan-zheng is working on.
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Aug 17, 2019
| for (auto i : range(tupleType->getNumElements())) | ||
| result.push_back(builder.createTupleExtract(val.getLoc(), val, i)); | ||
| else | ||
| if (auto tupleType = val->getType().getAs<TupleType>()) { |
There was a problem hiding this comment.
Just FYI: another version of extractAllElements lives in SILGenPoly.cpp.
It calls SILBuilder:: emitDestructureValueOperation.
bartchr808
reviewed
Aug 17, 2019
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
3 similar comments
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves Differentiation before OwnershipModelEliminator. Now Differentiation happens right after DefiniteInitialization.
Changes
Activity analysis
store_borrowinstructions.mayReadFromMemory()case. Remove special handlingmayReadFromMemory()and propagate usefulness through all buffer operands instead.destructure_tupleinstead oftuple_extractin array literal initialization pattern matcher.autodiff_functioncanonicalizationcopyParameterArgumentsForApply, used inreapplyFunctionConversionsand the curry thunk cloning logic inADContext::promoteToDifferentiableFunction.VJPEmitter
@guaranteedtrampoline argument needs to have a lifetime-ending use past its destination argument's lifetime-ending uses, so we keep track of these pairs of arguments intrampolinedGuaranteedPhiArgumentsand emitend_borrows when function cloning is finished.cond_brinstructions to conform to ownership rules.PullbackEmitter
@ownedownership, for both function arguments and phi arguments.@ownedownership.@guaranteedarguments. We should change this in the future so that all calls to pullbacks consume their arguments. (TF-761)switch_enumeven if there is only one successor. It no longer triggers any verification failure.• Remove the TF-585 workaround (emitting a
fix_lifetimeon boxed enums) since the crasher in AllocBoxToStack is no longer reproducible.destructure_tupleinstead oftuple_extractin array literal initialization adjoint emission logic.destructure_tuple,load_borrow,store_borrow,copy_value, andbegin_borrow.Resolves TF-709 and TF-585. Also improves some source locations in diagnostics since the differentiation transform runs on a higher-level IR.