Driver: Don't imply -enable-anonymous-context-mangled-names with optimizations enabled, even if -g is used. #26167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@eeckstein Is it worth adding a test that the relevant metadata is stripped with this option on? |
DougGregor
approved these changes
Jul 16, 2019
jrose-apple
reviewed
Jul 17, 2019
lib/Driver/ToolChains.cpp
Outdated
| // But don't add the option in optimized builds: it would prevent dead code | ||
| // stripping of unused metadata. | ||
| auto OptArg = inputArgs.getLastArgNoClaim(options::OPT_O_Group); | ||
| if (!OptArg || OptArg->getOption().getID() == options::OPT_Onone) |
There was a problem hiding this comment.
Nitpick: OptArg->getOption().matches(options::OPT_Onone). That'll handle aliases for -Onone if we ever add them.
There was a problem hiding this comment.
Thanks, I changed it.
…mizations enabled, even if -g is used. The option -enable-anonymous-context-mangled-names prevents stripping of dead metadata to improve debuggability. But with optimizations enabled, we do a lot of dead code stripping which affects debuggability anyway. rdar://problem/48123944
|
@slavapestov Yes it is! I added a test case. |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option -enable-anonymous-context-mangled-names prevents stripping of dead metadata to improve debuggability.
But with optimizations enabled, we do a lot of dead code stripping which affects debuggability anyway.
rdar://problem/48123944