Skip to content

Remove constexpr to satisfy MSVC being what it is. #26192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2019
Merged

Remove constexpr to satisfy MSVC being what it is. #26192

merged 1 commit into from
Jul 17, 2019

Conversation

gottesmm
Copy link
Contributor

No description provided.

@gottesmm
Copy link
Contributor Author

@drodriguez

@gottesmm
Copy link
Contributor Author

@swift-ci please test Windows platform

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@compnerd
Copy link
Member

Yeah, don't think that drop_front is a constexpr expression, thanks for fixing this @gottesmm

drodriguez
drodriguez approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@drodriguez drodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error in Windows seems to be an unrelated flaky test. I was not sure the constexpr could be removed, but if it is not necessary, away with it :D

@drodriguez drodriguez merged commit b479db0 into swiftlang:master Jul 17, 2019
@gottesmm gottesmm deleted the pr-c08ae1abeba47206bc05b6bd5f09f221128960cb branch July 23, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drodriguez drodriguez drodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gottesmm @compnerd @drodriguez