Skip to content

Try letting NSDictionary duck-typecheck things instead of doing it ourselves the slow way #26194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

Catfish-Man
Copy link
Contributor

@Catfish-Man Catfish-Man commented Jul 17, 2019

Fixes https://bugs.swift.org/browse/SR-11154

Fixes rdar://problem/53229663

@Catfish-Man Catfish-Man self-assigned this Jul 17, 2019
@Catfish-Man Catfish-Man force-pushed the if-it-quacks-like-a-key branch 3 times, most recently from 5809b13 to 0fde1fc Compare July 17, 2019 22:17
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Improvement OLD NEW DELTA RATIO
JSONPerfEncode 282 256 -9.2% 1.10x (?)
PlistPerfEncode 267 244 -8.6% 1.09x (?)

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
FlattenListLoop 2151 2658 +23.6% 0.81x (?)
DataSetCountSmall 74 80 +8.1% 0.93x (?)
 
Improvement OLD NEW DELTA RATIO
PlistPerfEncode 269 242 -10.0% 1.11x (?)
JSONPerfEncode 284 256 -9.9% 1.11x (?)

Code size: -Osize

Performance: -Onone

Improvement OLD NEW DELTA RATIO
JSONPerfEncode 293 262 -10.6% 1.12x (?)
PlistPerfEncode 276 251 -9.1% 1.10x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

… ourselves with a full (slow) conformance check
@Catfish-Man Catfish-Man force-pushed the if-it-quacks-like-a-key branch from 0fde1fc to 5e83f80 Compare July 18, 2019 00:48
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test and merge

2 similar comments
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test and merge

@shahmishal
Copy link
Member

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 70d4630 into swiftlang:master Jul 18, 2019
@Catfish-Man Catfish-Man deleted the if-it-quacks-like-a-key branch July 18, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants