Don’t try to build static stdlibs on macOS package bots #26198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have not been supported since ABI stability and we recently added an error that causes some tests to fail.
|
@swift-ci Please Build Toolchain macOS Platform |
|
macOS Toolchain Install command |
|
Merged to unblock package bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have not been supported since ABI stability and we recently added an error that causes some tests to fail.
This is a mildly quick-and-dirty fix to unblock the package bots; we should probably modify the cmake scripts to not build the static variants of these libraries for Darwin platforms even if they're requested. Otherwise we will need to modify additional presets, including some that are shared between Darwin and other platforms.
I have not been able to test this locally, so I'm going to ask Swift CI to build a macOS toolchain with this PR. If it succeeds, this should be safe to merge.