-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[CSDiag] Add a new diagnostic for @propertyWrapper implicit init call missing arguments #26219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@swift-ci please test |
Build failed |
Build failed |
Linux failure is unrelated |
@swift-ci please test Linux platform |
Thank you! I think this should be cherry-picked to 5.1 as well. |
@theblixguy Sorry, at this point there are only critical fixes taken in into 5.1 branch. |
ah okay no problem! |
We were emitting the fix-it in the wrong location for an implicitly generated
@propertyWrapper
initializer call expression, becausemissingArgument()
was not handling it correctly.Since emitting the correct fix-it is a bit tricky, this PR adds a new tailored diagnostic for this scenario.
Resolves SR-11060.
Resolves rdar://problem/52593306