[Type checker] Classes don't need backing properties to create their implicit constructors #26239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
This was fixed by pull request swiftlang#26174, but the test case there was specific to property wrappers, while the fix also addresses issues with other ambiguity name lookups such as protocol names in an inheritance clause.
…implicit constructors Fixes a crash caused by an undiagnosed cycle, rdar://problem/52679284.
Recent improvements in the laziness of the type checker mean that we weren't guaranteed to get the backing storage property always synthesized for a wrapped (static) property. Make sure that we create the backing storage property when walking a source file.
DougGregor
force-pushed
the
property-wrappers-rdar52679284
branch
from
f57c43d to
10680e4
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash caused by an undiagnosed cycle, rdar://problem/52679284.