[Diagnostics][Darwin] Diagnose libarclite not found on darwin toolchain #26261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
Jul 22, 2019
There was a problem hiding this comment.
Good find! I think we should probably go with a warning to not break anyone's existing flow, even if it's not quite doing what the usual default behavior is. (That means keeping the "if it doesn't exist" behavior too.) It's a little unfortunate that it'll have to run xcrun twice, but that's not the end of the world.
Do you think we should mention the -no-link-objc-runtime flag to silence the warning?
beccadax
requested changes
Jul 22, 2019
LucianoPAlmeida
force-pushed
the
fixme-diagnose-darwin-toolchain-arclib
branch
from
c5cd80e to
49efa57
Compare
beccadax
approved these changes
Jul 25, 2019
|
@swift-ci please test |
|
The tests passed, so this should be good to go? :)) |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys :)
Note a FIXME comment about diagnostics that could be done when linking to objc runtime, but the place was not a good one to emit diagnostics since it is in the construct invocation.
And since now there is a method in the toolchain to perform validations, thought that may be a good idea to handle that diagnostic there.
What do you think? cc @jrose-apple @brentdax
Obs: not sure if this diagnose message is good, maybe could be a better one :))