Fix usage of uninitialized memory in swift_addNewDSOImage. #26275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
This should address https://bugs.swift.org/browse/SR-6848. Couldn't transform the unsafeGet to get because it would produce an infinite loop.
|
@swift-ci please test linux |
|
Build failed |
|
@swift-ci please test macos |
|
Build failed |
DougGregor
approved these changes
Aug 13, 2019
|
@mikeash this make sense to you as well? |
|
@pschuh sorry for the delay. I got buried in mentions while on vacation and am digging out |
|
Looks good to me! |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address https://bugs.swift.org/browse/SR-6848.
Couldn't transform the unsafeGet to get() because it would produce an infinite loop due to the fact that this gets called in the constructor. All non-reentrant versions will continue to use the safe version.