Print attributes on enum cases correctly (like 'indirect') #26311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
harlanhaskins
approved these changes
Jul 23, 2019
|
Thanks for adding the verifier check too. |
|
Build failed |
Previously they were just skipped if enum elements weren't exploded into their own individual lines, since the ASTPrinter assumed they'd be present on the EnumCaseDecl. This led to miscompiles when using a module interface for an enum with indirect cases, since they'd be printed as non-indirect cases. rdar://problem/53329452
jrose-apple
force-pushed
the
indirectly-responsible
branch
from
d35ec61 to
f54c39b
Compare
|
Build failed |
|
Build failed |
rintaro
reviewed
Jul 24, 2019
| indirect case b(Int) | ||
| // CHECK-NEXT: {{^}} case c{{$}} | ||
| case c | ||
| } |
There was a problem hiding this comment.
Do you think it's worth to add test cases for multi element case decl? e.g.
enum Something {
indirect case a(Int), b(Int)
case c
}There was a problem hiding this comment.
Mm, good point. This is a time-sensitive fix so I'll do it in a follow-up.
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jul 24, 2019
…#26311) Previously they were just skipped if enum elements weren't exploded into their own individual lines, since the ASTPrinter assumed they'd be present on the EnumCaseDecl. This led to miscompiles when using a module interface for an enum with indirect cases, since they'd be printed as non-indirect cases. rdar://problem/53329452 (cherry picked from commit 3596df7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously they were just skipped if enum elements weren't exploded into their own individual lines, since the ASTPrinter assumed they'd be present on the EnumCaseDecl. This led to miscompiles when using a module interface for an enum with indirect cases, since they'd be printed as non-indirect cases.
rdar://problem/53329452