Reconcile differences from upstream finishApplyDynamicCallable. #26320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
LGTM if tests pass!
I believe this at least partially resolves TF-217. I tried to upstream to master some @dynamicCallable-fixed-crasher tests, but didn't create Python-independent reproducers. Consider closing the issue if it makes sense to you. 🙂
|
This is not exactly in sync. What is missing from master is the coercion logic. |
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
Should now be perfectly in sync. |
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some differences, but this is a pre-step to resolving those.