Skip to content

Upstream bug fix related to keyword argument dynamic callable. #26322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2019
Merged

Upstream bug fix related to keyword argument dynamic callable. #26322

merged 1 commit into from
Jul 25, 2019

Conversation

pschuh
Copy link
Contributor

@pschuh pschuh commented Jul 24, 2019

Failure to coerce the tuple dynamic callable parameter crashes the compiler.

The error looks like:

tuple_expr element type mismatch:
  field: Any
  element: Int

@pschuh pschuh requested a review from dan-zheng July 24, 2019 00:27
@pschuh
Copy link
Contributor Author

pschuh commented Jul 24, 2019

@swift-ci please test

@dan-zheng dan-zheng requested a review from xedin July 24, 2019 00:33
xedin
xedin requested changes Jul 24, 2019
View reviewed changes
@pschuh
Copy link
Contributor Author

pschuh commented Jul 24, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 814709f4bfdba8774a39b0beb1b2ea39e33a9611

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 814709f4bfdba8774a39b0beb1b2ea39e33a9611

@pschuh pschuh requested a review from xedin July 24, 2019 03:28
slavapestov
slavapestov approved these changes Jul 24, 2019
View reviewed changes
@pschuh
Copy link
Contributor Author

pschuh commented Jul 24, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b9a51f7df025bc7c98ee7d79356a7689c3cda8ac

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b9a51f7df025bc7c98ee7d79356a7689c3cda8ac

xedin
xedin reviewed Jul 25, 2019
View reviewed changes
xedin
xedin approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@pschuh
Copy link
Contributor Author

pschuh commented Jul 25, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6c00c740562be6bbd9b8efaa639c5eafac90704e

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 6c00c740562be6bbd9b8efaa639c5eafac90704e

@pschuh pschuh merged commit 3fdb42f into swiftlang:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

@xedin xedin xedin approved these changes

@dan-zheng dan-zheng dan-zheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pschuh @swift-ci @xedin @slavapestov @dan-zheng