[CMake] add_swift_target_library shouldn't implicitly set INSTALL_IN_TARGET #26340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
bulbazord
force-pushed
the
make-explicit-the-implicit
branch
from
c4dce56 to
2603bef
Compare
|
@swift-ci please smoke test |
…TARGET This makes it more explicit what the install component of a target library is if you don't see one (and its marked as IS_SDK_OVERLAY). Explicit in this case makes more sense, as you don't have to rely on knowledge of how `add_swift_target_library` is implemented to understand what component is used to install the target.
bulbazord
force-pushed
the
make-explicit-the-implicit
branch
from
2603bef to
184d942
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
I appreciate that you're making this explicit. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more explicit what the install component of a target
library is if you don't see one (and its marked as IS_SDK_OVERLAY).
Explicit in this case makes more sense, as you don't have to rely on
knowledge of how
add_swift_target_libraryis implemented to understandwhat component is used to install the target.
cc @compnerd @gottesmm @Rostepher