Skip to content

Check default init before synthesizing wrapper backing properties. #26352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jckarter
Copy link
Contributor

Fixes a regression where the compiler would reject something like:

@State var x: Int?

as not having an initializer, even though an Int? property ought to default to nil.
rdar://problem/53504653

@jckarter jckarter requested a review from DougGregor July 25, 2019 17:02
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter
Copy link
Contributor Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 09716de81bcff2fd0107817fb8a6592a3df5eac9

@jckarter
Copy link
Contributor Author

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 09716de81bcff2fd0107817fb8a6592a3df5eac9

@jckarter
Copy link
Contributor Author

@swift-ci Please test Linux

@jckarter jckarter force-pushed the property-wrapper-optional-nil-default-master branch from 09716de to a840194 Compare July 25, 2019 21:42
Fixes a regression where the compiler would reject something like:

  @State var x: Int?

as not having an initializer, even though an Int? property ought to default to nil.
rdar://problem/53504653
@jckarter jckarter force-pushed the property-wrapper-optional-nil-default-master branch from a840194 to 0c13a4b Compare July 25, 2019 22:17
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter
Copy link
Contributor Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 09716de81bcff2fd0107817fb8a6592a3df5eac9

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 09716de81bcff2fd0107817fb8a6592a3df5eac9

@jckarter jckarter merged commit ce20a30 into swiftlang:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants