Sema: implement getInitKind using a request evaluator.
#26377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than (indirectly) calling `getInitKind` When we requestify `getInitKind`, we don't want to invoke the request during parsing. What the parsing code really cares about is whether or not the decl has `ConvenienceAttr`.
…lWitnessWarningWithMovement`
Add the request `InitKind` to lazily compute the kind of an initializer declaration.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
xymus
approved these changes
Jul 27, 2019
slavapestov
approved these changes
Jul 27, 2019
Don't use `else` after a `return`.
Use `getSelfNominalTypeDecl` rather than `getDeclaredInterfaceType` in `InitKindRequest::evaluate`, since it's cheaper to perform.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conveniencerather than (indirectly) callinggetInitKindInitKindRequestrequest during parsing. What the parsing code really cares about is whether or not the decl hasConvenienceAttr.ConstructorDeclas a part of error recovery when type checking its body.canSuppressPotentialWitnessWarningWithMovementInitKindRequestto lazily compute the kind of an initializer declaration.