Skip to content

test: adjust declaration to be portable (NFCI) #26387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

compnerd
Copy link
Member

long is teated as Int32 on Windows x86_64. intptr_t will be
mapped to Int and Int64. This fixes the failing test on Windows
which is LLP64 and should be equivalent on LP64 targets.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

`long` is teated as `Int32` on Windows x86_64.  `intptr_t` will be
mapped to `Int` and `Int64`.  This fixes the failing test on Windows
which is LLP64 and should be equivalent on LP64 targets.
@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

CC: @xedin

@compnerd compnerd merged commit 37abe9d into swiftlang:master Jul 28, 2019
@compnerd compnerd deleted the llp64-is-a-must branch July 28, 2019 19:39
@xedin
Copy link
Contributor

xedin commented Jul 28, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants